Address PR review feedback

- heft-lint-plugin: resolve TypeScript program root file names against the
  project folder (not the process cwd), and derive the project-relative ESLint
  patterns by slicing the project-folder prefix instead of using path.relative.
- @rushstack/eslint-config: drop the derived nonTypeAwareRules export/loop and
  keep only the explicit typeAwareRules group; simplify the
  without-type-information helper to an explicit disabled-rules list.
- Defer the decoupled-local-node-rig / node-rig wiring to a follow-up PR (to be
  done after @rushstack/eslint-config is published and the dependency is bumped);
  fix @rushstack/playwright-browser-tunnel inline in its own eslint.config.js for
  now.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: iclanton

apps/playwright-browser-tunnel/eslint.config.js

@@ -3,9 +3,6 @@
 
 const nodeTrustedToolProfile = require('local-node-rig/profiles/default/includes/eslint/flat/profile/node-trusted-tool');
 const friendlyLocalsMixin = require('local-node-rig/profiles/default/includes/eslint/flat/mixins/friendly-locals');
-const {
-  withoutTypeInformation
-} = require('local-node-rig/profiles/default/includes/eslint/flat/without-type-information');
 
 module.exports = [
   ...nodeTrustedToolProfile,
@@ -18,7 +15,23 @@ module.exports = [
       }
     }
   },
-  // The Playwright config and test files are not part of the project's TypeScript program (they are excluded
-  // from tsconfig.json), so lint them with only the non-type-aware rules.
-  ...withoutTypeInformation({ files: ['playwright.config.ts', 'tests/**/*.ts'] })
+  {
+    // The Playwright config and test files are not part of the project's TypeScript program (they are excluded
+    // from tsconfig.json), so disable type-aware parsing and the profile's type-aware rules and lint them with
+    // only the non-type-aware rules.
+    // TODO: Replace this with the `@rushstack/eslint-config` `without-type-information` helper once that package
+    // is published and consumed by the node rigs.
+    files: ['playwright.config.ts', 'tests/**/*.ts'],
+    languageOptions: {
+      parserOptions: {
+        project: false,
+        projectService: false
+      }
+    },
+    rules: {
+      '@typescript-eslint/naming-convention': 'off',
+      '@typescript-eslint/no-floating-promises': 'off',
+      '@typescript-eslint/no-for-in-array': 'off'
+    }
+  }
 ];

common/changes/@rushstack/eslint-config/heft-lint-flat-config-files_2026-09-12-04-00-00.json

@@ -2,7 +2,7 @@
   "changes": [
     {
       "packageName": "@rushstack/eslint-config",
-      "comment": "Group the type-aware rules separately (exposed as `typeAwareRules`/`nonTypeAwareRules`) and add a `flat/without-type-information` helper for linting files that are not part of the TypeScript program with only the non-type-aware rules.",
+      "comment": "Group the profile's type-aware rules into an exported `typeAwareRules` set and add a `flat/without-type-information` helper for linting files that are not part of the TypeScript program with only the non-type-aware rules.",
       "type": "minor"
     }
   ]

eslint/eslint-config/flat/profile/_common.js

@@ -785,18 +785,4 @@ const commonConfig = [
   }
 ];
 
-// Derive the non-type-aware rule group from the authored TypeScript source-file config so that it stays in sync
-// with the rules above. Everything that is not part of typeAwareRules can be applied to files that lack type
-// information.
-const typeScriptSourceFileConfig = commonConfig.find(
-  (configObject) =>
-    Array.isArray(configObject.files) && configObject.files.includes('**/*.ts') && configObject.rules
-);
-const nonTypeAwareRules = {};
-for (const [ruleName, ruleValue] of Object.entries(typeScriptSourceFileConfig.rules)) {
-  if (!(ruleName in typeAwareRules)) {
-    nonTypeAwareRules[ruleName] = ruleValue;
-  }
-}
-
-module.exports = { commonNamingConventionSelectors, commonConfig, typeAwareRules, nonTypeAwareRules };
+module.exports = { commonNamingConventionSelectors, commonConfig, typeAwareRules };

eslint/eslint-config/flat/without-type-information.js

@@ -1,7 +1,13 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-const { typeAwareRules } = require('./profile/_common');
+// The profile's type-aware rules, turned off. Keep this in sync with the typeAwareRules group in
+// ./profile/_common.js.
+const disabledTypeAwareRules = {
+  '@typescript-eslint/naming-convention': 'off',
+  '@typescript-eslint/no-floating-promises': 'off',
+  '@typescript-eslint/no-for-in-array': 'off'
+};
 
 // Returns ESLint flat-config objects that lint the specified files WITHOUT type information: type-aware parsing
 // is disabled and the profile's type-aware rules are turned off, leaving only the non-type-aware rules in effect.
@@ -11,9 +17,6 @@ const { typeAwareRules } = require('./profile/_common');
 // this, typescript-eslint reports a fatal parsing error because it cannot associate those files with the project,
 // and any type-aware rule would be unable to run.
 //
-// If your ESLint configuration layers additional type-aware rules on top of this profile, pass their rule names
-// via "additionalTypeAwareRuleNames" so that they are disabled as well.
-//
 // IMPORTANT: These config objects must be included in your ESLint configuration AFTER the profile, so that they
 // override the profile's type-aware parser options and rules for the specified files.
 //
@@ -25,12 +28,7 @@ const { typeAwareRules } = require('./profile/_common');
 //     ...nodeTrustedToolProfile,
 //     ...withoutTypeInformation({ files: ['tests/**/*.ts', 'playwright.config.ts'] })
 //   ];
-function withoutTypeInformation({ files, additionalTypeAwareRuleNames = [] }) {
-  const disabledTypeAwareRules = {};
-  for (const ruleName of [...Object.keys(typeAwareRules), ...additionalTypeAwareRuleNames]) {
-    disabledTypeAwareRules[ruleName] = 'off';
-  }
-
+function withoutTypeInformation({ files }) {
   return [
     {
       files,

eslint/local-eslint-config/.gitignore

@@ -1,4 +1,3 @@
 /flat/mixins
 /flat/patch
-/flat/profile
-/flat/without-type-information.js
+/flat/profile

heft-plugins/heft-lint-plugin/src/Eslint.ts

@@ -140,7 +140,7 @@ export class Eslint extends LinterBase<
     this.#sarifLogPath = sarifLogPath;
 
     this.#typeScriptFilenames = new Set(
-      tsProgram.getRootFileNames().map((filePath: string) => path.resolve(filePath))
+      tsProgram.getRootFileNames().map((filePath: string) => path.resolve(buildFolderPath, filePath))
     );
     // ESLint configuration paths are relative to the project folder. Compute the project-relative paths of the
     // files in the TypeScript program so that the injected program can be scoped to just those files, and so
@@ -149,7 +149,9 @@ export class Eslint extends LinterBase<
     const typeScriptFilePatterns: string[] = [];
     for (const filePath of this.#typeScriptFilenames) {
       if (Path.isUnder(filePath, buildFolderPath)) {
-        typeScriptFilePatterns.push(Path.convertToSlashes(path.relative(buildFolderPath, filePath)));
+        // filePath is already an absolute path under buildFolderPath, so strip the prefix (plus the separator)
+        // instead of recomputing the relative path.
+        typeScriptFilePatterns.push(Path.convertToSlashes(filePath.slice(buildFolderPath.length + 1)));
       }
     }
 

heft-plugins/heft-lint-plugin/src/LintPlugin.ts

@@ -307,25 +307,29 @@ export default class LintPlugin implements IHeftTaskPlugin<ILintPluginOptions> {
     heftConfiguration: HeftConfiguration,
     tsPrograms: IExtendedProgram[]
   ): string[] {
+    const { buildFolderPath } = heftConfiguration;
     const outputFolderPaths: Set<string> = new Set();
     for (const tsProgram of tsPrograms) {
       const { outDir, declarationDir } = tsProgram.getCompilerOptions();
       if (outDir) {
-        outputFolderPaths.add(outDir);
+        outputFolderPaths.add(path.resolve(buildFolderPath, outDir));
       }
 
       if (declarationDir) {
-        outputFolderPaths.add(declarationDir);
+        outputFolderPaths.add(path.resolve(buildFolderPath, declarationDir));
       }
     }
 
-    const { buildFolderPath } = heftConfiguration;
-    return Array.from(outputFolderPaths, (outputFolderPath: string) => {
-      const relativePath: string = Path.convertToSlashes(path.relative(buildFolderPath, outputFolderPath));
-      return `${relativePath}/**`;
-    }).filter(
-      (relativePath: string) =>
-        relativePath !== '/**' && relativePath !== '../**' && !relativePath.startsWith('../')
-    );
+    const ignorePatterns: string[] = [];
+    for (const outputFolderPath of outputFolderPaths) {
+      // Only output folders under the project folder can be expressed as ESLint ignore patterns.
+      if (Path.isUnder(outputFolderPath, buildFolderPath)) {
+        ignorePatterns.push(
+          `${Path.convertToSlashes(outputFolderPath.slice(buildFolderPath.length + 1))}/**`
+        );
+      }
+    }
+
+    return ignorePatterns;
   }
 }

rigs/decoupled-local-node-rig/profiles/default/includes/eslint/flat/profile/_common.js

@@ -11,51 +11,6 @@ const headersEslintPlugin = require('eslint-plugin-headers');
 
 const nodeImportResolverPath = require.resolve('eslint-import-resolver-node');
 
-// These localCommonConfig rules require type information (i.e. the TypeScript program). They are grouped
-// separately so that TypeScript files which are NOT part of the project's TypeScript program can be linted with
-// only the non-type-aware rules. See the "without-type-information" helper.
-const localTypeAwareRules = {
-  // Rationale: Use of `void` to explicitly indicate that a floating promise is expected
-  // and allowed.
-  '@typescript-eslint/no-floating-promises': [
-    'error',
-    {
-      ignoreVoid: true,
-      checkThenables: true
-    }
-  ],
-
-  // Docs: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/naming-convention.md
-  '@typescript-eslint/naming-convention': [
-    'warn',
-    ...expandNamingConventionSelectors([
-      ...commonNamingConventionSelectors,
-      {
-        selectors: ['method'],
-        modifiers: ['async'],
-        enforceLeadingUnderscoreWhenPrivate: true,
-
-        format: null,
-        custom: {
-          regex: '^_?[a-zA-Z]\\w*Async$',
-          match: true
-        },
-        leadingUnderscore: 'allow',
-
-        filter: {
-          regex: [
-            // Specifically allow ts-command-line's "onExecute" function.
-            '^onExecute$'
-          ]
-            .map((x) => `(${x})`)
-            .join('|'),
-          match: false
-        }
-      }
-    ])
-  ]
-};
-
 module.exports = {
   localCommonConfig: [
     {
@@ -87,9 +42,15 @@ module.exports = {
         // understand where the dependency is coming from.
         '@rushstack/normalized-imports': 'warn',
 
-        // Type-aware rules (require the TypeScript program) are grouped in localTypeAwareRules so that files
-        // outside the TypeScript program can be linted with only the non-type-aware rules.
-        ...localTypeAwareRules,
+        // Rationale: Use of `void` to explicitly indicate that a floating promise is expected
+        // and allowed.
+        '@typescript-eslint/no-floating-promises': [
+          'error',
+          {
+            ignoreVoid: true,
+            checkThenables: true
+          }
+        ],
 
         // Rationale: Redeclaring a variable likely indicates a mistake in the code.
         'no-redeclare': 'off',
@@ -149,6 +110,36 @@ module.exports = {
           }
         ],
 
+        // Docs: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/naming-convention.md
+        '@typescript-eslint/naming-convention': [
+          'warn',
+          ...expandNamingConventionSelectors([
+            ...commonNamingConventionSelectors,
+            {
+              selectors: ['method'],
+              modifiers: ['async'],
+              enforceLeadingUnderscoreWhenPrivate: true,
+
+              format: null,
+              custom: {
+                regex: '^_?[a-zA-Z]\\w*Async$',
+                match: true
+              },
+              leadingUnderscore: 'allow',
+
+              filter: {
+                regex: [
+                  // Specifically allow ts-command-line's "onExecute" function.
+                  '^onExecute$'
+                ]
+                  .map((x) => `(${x})`)
+                  .join('|'),
+                match: false
+              }
+            }
+          ])
+        ],
+
         // Require `node:` protocol for imports of Node.js built-in modules
         'import/enforce-node-protocol-usage': ['warn', 'always'],
 
@@ -224,6 +215,5 @@ module.exports = {
         'import/no-duplicates': 'off'
       }
     }
-  ],
-  localTypeAwareRules
+  ]
 };