Allow undefined standardized bootstrap draws without aborting estimation - #240
Open
lllleolin-max wants to merge 1 commit into
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220. With three observations per group, some bootstrap resamples are constant. Cohen's d currently raises on their zero pooled variance and aborts the whole analysis, including Hedges' g, even when the observed samples have a well-defined effect.
Handle these degenerate draws specifically inside the bootstrap loop, retaining explicit infinite/NaN values for the existing warning and interval handling. The observed effect and direct public effect-size/permutation routines retain their existing zero-variance errors.
The regressions exercise
dabest.loadfor both standardized effects at n=3, check the warning and finite observed effect/BCa bounds, and ensure all-constant original data still fail clearly instead of producing a p-value.Validation: regression tests fail on the pinned
vnbdevsource and pass with this change; regression tests plus the existing load-error suite pass on Windows / Python 3.12 with NumPy 2.1.3 and SciPy 1.15.3. Notebook sources were edited and their Python modules regenerated with nbdev.AI assistance: Codex with GPT-6 Astra was used to develop and test this patch.