docs(design-system): principle 29 — a toggle should not shove the rest of the panel, verified by eye - #2770
Merged
Merged
Conversation
…t of the panel, verified by eye Section B (layout stability) covered shifts caused by data arriving and context loss on refresh, but nothing addressed a user-driven change: a toggle revealing dependent fields, a mode swapping a column, a tab switch. That class has shipped and been fixed four times (#954, #1563, #1939, #2640). Added as a recommendation, not a hard rule: prefer a reserved footprint or a height/flex transition over a bare v-if snap, with the trigger staying under the pointer and the user's reading position kept in view. No scanner can see layout movement, so the PR self-check asks for a human to exercise the control in the browser, in both themes, and say so. Both docs updated; CLAUDE.md principle count bumped to 29. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FigLSz2mrmmWyXF1HCt6Zq
vybe
approved these changes
Sep 14, 2026
vybe
left a comment
vybe
left a comment
Contributor
There was a problem hiding this comment.
merge-train: batch validated on train/20260914-1332
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds UI Construction Principle 29 to
docs/memory/design-system.mdand the builder contract, plus a do/don't row and a PR self-check item. Bumps the principle count inCLAUDE.mdto 29.Why
Section B ("Layout stability — no jumpy UI") covered shifts caused by data arriving (principles 4, 6) and context loss on refresh (5). Nothing covered a user-driven change — a toggle revealing dependent fields, a mode swapping a column, a tab switch. That class has shipped and been fixed four times: #954, #1563, #1939, #2640.
Shape of the rule
A recommendation, not a hard rule, and explicitly verified by eye:
motion-reduce:transition-none) over a barev-ifsnap.Docs only. No code, no ratchet, no CI change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FigLSz2mrmmWyXF1HCt6Zq