Fix ActorProxy AttributeError naming the metaclass instead of the interface - #1209
Open
magic-peach wants to merge 1 commit into
Open
Fix ActorProxy AttributeError naming the metaclass instead of the interface#1209magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
…erface self._actor_interface is already the interface class, not an instance, so self._actor_interface.__class__ returned its metaclass (ABCMeta) instead of the actor interface's own name. Use __name__ instead. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
self._actor_interface is already the interface class, not an instance, so self._actor_interface.class returned its metaclass (ABCMeta) instead of the actor interface's own name in the AttributeError message raised for an unknown method. Use name instead so the error actually names the interface.
Added a test asserting the AttributeError message names the real interface class.
Issue reference
No existing issue tracks this; found while reviewing the actor client proxy.
Checklist