fix(sessions): reject a duplicate session id instead of overwriting the session - #1503
Open
copybara-service[bot] wants to merge 1 commit into
Open
fix(sessions): reject a duplicate session id instead of overwriting the session#1503copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…he session `InMemorySessionService.createSession` replaced the stored session when handed a `sessionId` already in use, discarding its events and state and returning an empty session. It now errors with `SessionAlreadyExistsException`, a new subclass of `SessionException`, matching Python and Go. PiperOrigin-RevId: 978199397
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(sessions): reject a duplicate session id instead of overwriting the session
InMemorySessionService.createSessionreplaced the stored session when handed asessionIdalready in use, discarding its events and state and returning anempty session. It now errors with
SessionAlreadyExistsException, a new subclassof
SessionException, matching Python and Go.